Pull requests are the primary unit of work within the Fidesctl project. All code changes are expected to be submitted via a PR, and as such here are a few requirements for submitting PRs:
- Completely fill out the provided pull request template.
- PRs should be in a
draftstate until they are ready for a final review + merge. A non-draft PR signals to the community that the author believes the PR is ready to ship! If you need early feedback on your PR, feel free to ask for it directly while your PR is in a draft state.
- Make sure that all checks are passing and all boxes have been checked before taking the PR out of a
draftstate. PR reviews require other people to spend their time, so please be courteous and double check your work before passing it to a reviewer.
- If you're unsure about a potential feature implementation or there is anything else that needs discussing, feel free to ask for an early review/feedback in the comments of the draft PR.
- PRs should be focused, reflecting a single logical change or feature. Generally, it is better to have multiple smaller PRs than one big one. This reduces the merge risk and shortens review time.